Skip to content

CI: don't fail ci-success on runs triggered by closing a PR - #24

Merged
lkdvos merged 1 commit into
mainfrom
ci-closed-fix
Oct 29, 2026
Merged

lkdvos merged 1 commit into
mainfrom
ci-closed-fix

Conversation

@lkdvos

@lkdvos lkdvos commented Oct 29, 2026

Copy link
Copy Markdown
Member

Since #23, closing or merging a PR triggers a Tests run that only exists to cancel the PR's in-progress runs, and the shared workflow skips all of its test jobs. The ci-success job ran with if: always() and treated the skipped tests result as a failure, so every closed PR got a failing ci-success check. It is now skipped for closed events, as in the shared TestGroups workflow.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos
lkdvos merged commit 8c43ef0 into main Oct 29, 2026
4 checks passed
@lkdvos
lkdvos deleted the ci-closed-fix branch October 29, 2026 15:26
@github-actions

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant