Repository navigation
Smaller cleanups - #12
Open
borisdevos wants to merge 23 commits into
Open
borisdevos wants to merge 23 commits into
borisdevos wants to merge 23 commits into
Conversation
…allunits in the fallback
…ng and not hard-coding size
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
lkdvos
reviewed
Oct 30, 2026
| end | ||
|
|
||
| Base.size(::Type{A4Object}) = 7 | ||
| Base.size(I::Type{<:BimoduleSector}) = size(_get_dual_cache(I)[3], 1) |
Member
There was a problem hiding this comment.
Looking at this I no longer really remember why we have this definition and it looks a bit odd to me, typically size(x) returns a tuple so maybe this should be (7,) instead, but do you remember what we use this for?
lkdvos
reviewed
Oct 30, 2026
| data_dict = Dict{NTuple{3, Int}, Dict{NTuple{3, Int}, Int}}() | ||
| for row in eachrow(Narray) | ||
| i, j, k, a, b, c, N = Int.(@view(row[1:size(I)])) | ||
| i, j, k, a, b, c, N = Int.(@view(row[1:7])) |
Member
There was a problem hiding this comment.
I guess this answers my previous question, does that mean we can remove the Base.size definition?
lkdvos
reviewed
Oct 30, 2026
Comment on lines
+11
to
+13
| [weakdeps] | ||
| TensorKit = "07d1fe3e-3e46-537d-9eac-e9e13d0d4cec" | ||
|
|
Member
There was a problem hiding this comment.
Why is this a weakdep? That category is typically for package extensions, which I don't think we are defining here?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides some refactors, there were some problems with #2 which I fixed here, in particular the unit and dual calculations. I'm surprised they didn't error previously.
Summary of the important parts:
sizeisn't hardcoded, so the first call to a sector goes through loading the Nsymbols firstWill have to revisit the readme after a package release