Repository navigation
Conversation
lkdvos
reviewed
Oct 29, 2026
Member
Author
|
I got a little carried away here. I think we can get rid of the vendor specific extensions and just use |
Member
|
Why is this packed columns (essentially: contiguous data) necessary. I thought |
Member
Author
|
The vendor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think our original approach here was wrong, because we can use the BLAS methods as long as the view that's passed is densely packed. So right now we aren't using BLAS where we could (a dense patch of a higher dimensional tensor, for example) and we are trying to use it in dangerous places. Hopefully this fixes both.