Repository navigation
Conversation
lkdvos
reviewed
Oct 29, 2026
| return keep | ||
| end | ||
|
|
||
| function _ind_to_mask!(keep::SectorVector{Bool}, inds::SectorVector{Bool}) |
Member
There was a problem hiding this comment.
Is there any (re)use of calling the _ind_to_mask! from MAK itself on the parents?
Member
Author
There was a problem hiding this comment.
MAK just has ind_to_mask (no !) that's not in place
Comment on lines
+351
to
+354
| to_keep = collect(parent(_ind_to_mask!(keep, inds))) | ||
| kept_values = collect(parent(values)) | ||
| perm = sortperm(kept_values; by = abs, rev = true) | ||
| MAK._keep_multiplets!(to_keep, kept_values, perm, strategy) |
Member
There was a problem hiding this comment.
Do we need the collect here? Does MAK not do this itself? In particular, if we can avoid doing it here, then better support in MAK automatically transfers.
Open
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.