Repository navigation
Fix the underbraiding hexagon equation for generic fusion - #119
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
borisdevos
approved these changes
Oct 28, 2026
borisdevos
left a comment
Member
There was a problem hiding this comment.
Should wait till tests pass for certainty, but this change does make sense. Silly of me to not have caught this myself, thanks for the fix!
lkdvos
enabled auto-merge (squash)
October 28, 2026 22:29
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
GenericFusionsectors, the second (underbraiding) equation inhexagon_equationusedconj(R)for the inverse braiding. The inverse of a unitary R-symbol is its adjoint, so the first two indices ofRace,RbcfandRgcdalso need to be swapped. This is the same fix that #92 made in the Artin braid test, and it matches what TensorKit uses forinv = truebraids (Rsymbol(b, a, c)'inbraidingtensor.jlandfusiontrees/braiding_manipulations.jl).The two versions differ only when an R-symbol is not symmetric. No sector in this package has such an R-symbol: the only one with multiplicities, the 2×2 R-symbol of
A4Irrep, is symmetric. So the existing tests pass either way. SU(3) irreps from SUNRepresentations.jl do have non-symmetric R-symbols. With TensorKitSectors' sector testsuite (QuantumKitHub/SUNRepresentations.jl#44), for example,hexagon_equation(SU3Irrep((4, 1, 0)), SU3Irrep((3, 0, 0)), SU3Irrep((4, 2, 0)))failed with a mismatch of 4e-2 before this PR. For the five SU(3) triples that failed there:The F- and R-symbols themselves are consistent with the SU(3) Clebsch–Gordan coefficients they are computed from: the F-move matches to 1e-12 and the R-move to 3e-15.
The multiplicity-free branch is unchanged, since R-symbols are scalars there.
🤖 Generated with Claude Code