fix(reporter): stop test-origin bullets gluing onto the cost line#176
Merged
Conversation
The test-origin-excluded row ended with a trailing `{% endif %}`. With
nunjucks `trimBlocks: true`, the newline after that tag is stripped, so
each query's `cost N` line ran straight into the next bullet
("cost 1- SELECT ..."). Append the same `{{""}}` guard the other rows
already use so the newline survives.
There was a problem hiding this comment.
Query Doctor Analysis
3 queries analyzed
0 regressed · 0 improved · 0 new · 0 removed
2 pre-existing issues
SELECT "guests"."id", "guests"."session_id", "guests"."username", "guests"."avatar_path", "guests"."color", "guests"."side", "guests"."audio_recording_path", "guests"."audio_recording_public", "gue...
indexassets(event_id, inserted_at desc)
cost 31,003,449 → 1,498 (100% reduction)SELECT * FROM guest_ip_addresses WHERE ip_address = '127.0.0.1';
indexguest_ip_addresses(ip_address)
cost 154,402 → 8 (100% reduction)
Using assumed statistics (10000000 rows/table). For better results, sync production stats.
More detail → get_ci_run({ runId: "019f5e83-4b0f-79bc-9314-bbed5f800ade" }) · view run · docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In the CI PR comment, the test-origin queries excluded from the gate list rendered the second query on the same line as the first query's
costlabel:Why
The template engine is configured with
trimBlocks: true(github.ts), which strips the newline immediately after a block tag. The test-origin row ended with a trailing{% endif %}, so that newline got eaten and the next-bullet glued onto the previous item's cost line. Every other row in this template already guards against this by appending{{""}}after the trailing{% endif %}— this section was the only one missing it.Fix
Append the same
{{""}}guard so the block tag is no longer the last token on the line and the newline survives.Test
Added a regression test that renders two excluded queries and asserts each starts its own bullet. Verified it fails without the fix (reproduces
cost 1- <code>…) and passes with it.