feat: add G64 command support for LinuxCNC, Fanuc, and Haas dialects - #154
Merged
Merged
Conversation
G64 was only defined for Siemens. This adds hover documentation and completion support for G64 in the remaining three dialects: - LinuxCNC: Path Blending with optional P (tolerance) and Q (naive cam) parameters - Fanuc: Cutting Mode (no deceleration at block boundaries, no parameters) - Haas: Cutting Mode (Fanuc-compatible, no parameters)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds G64 command definitions (hover documentation and auto-completions) to the LinuxCNC, Fanuc, and Haas dialect databases. G64 was previously only defined for the Siemens dialect.
Type of Change
Related Issues
N/A
Changes Made
LinuxcncGCodeCommandDatabase.ts): Added G64 as Path Blending mode with optionalP(path deviation tolerance) andQ(naive cam detector tolerance) parameters — the standard LinuxCNC path blending commandFanucGCodeCommandDatabase.ts): Added G64 as Cutting Mode (no deceleration at block boundaries) — the standard Fanuc path control mode, no parametersHaasGCodeCommandDatabase.ts): Added G64 as Cutting Mode — Fanuc-compatible, no parametersCHANGELOG.md: Added entry under[Unreleased] → AddedTesting
npm test— 1389 tests, 83 suites, all green)npm run build)Checklist
npm run typecheckvia build)npm run build)Additional Notes
Each dialect's G64 description explains the behavioural difference from the other modes (G61 exact stop, G63 tapping) so reviewers unfamiliar with CNC can understand the intent without consulting external docs.