fix(aorta): container /dev/kfd access and --override argument packing - #327
Merged
speriaswamy-amd merged 4 commits intoSep 11, 2026
Merged
speriaswamy-amd merged 4 commits into
speriaswamy-amd merged 4 commits into
Conversation
This was referenced Aug 14, 2026
speriaswamy-amd
force-pushed
the
surya/aorta-mn-02-single-node-fixes
branch
from
September 8, 2026 15:18
096db2e to
30e86de
Compare
speriaswamy-amd
force-pushed
the
surya/aorta-mn-02-single-node-fixes
branch
from
September 8, 2026 15:28
30e86de to
0feffb5
Compare
amd-droy
reviewed
Sep 9, 2026
Two defects on the existing single-node path, both surfaced by live cluster validation: - _launch_container() never passed `user`, so the container ran as the image's default UID (jenkins on the validation cluster) and could not open /dev/kfd despite --privileged. The `render` group was also missing. The function's own comment already claimed "Run as root so the container can access GPUs" - the code now matches it. - Training overrides were emitted as `--override k=v --override k2=v2`. Aorta's train.py declares `--override` with `nargs="*"`, so argparse keeps only the last group and every preceding override was silently dropped. All key=value tokens now sit behind a single `--override`. Extracts the env-building block out of run() into _build_base_env() so the override packing is unit-testable without a container. Co-Authored-By: Claude <noreply@anthropic.com>
group_add=["video", "render"] failed containers.run() outright on hosts without a "render" group. user="root" + privileged already grants /dev/kfd access; probe for "render" over SSH (same pattern as the existing UID/GID lookup) and only request it when present. AORTA_OVERRIDE_ARGS embedded literal quotes around each value (key="value"). Nothing downstream re-parses this as a shell, so the quote characters reached argparse as part of the value itself (training.max_steps="15" instead of 15). Emit bare key=value tokens.
…mmand AORTA_OVERRIDE_ARGS was computed and logged but never consumed -- exp_cmd never appended the --override tokens, so config-driven training overrides were silently dropped in script mode (AIMVT-292).
Docker resolves group_add names against the container image's /etc/group, not the host's, so a "render" group found on the host can fail to resolve inside the image even though the host device node needs that GID. Pass the numeric GID instead so it applies directly.
speriaswamy-amd
force-pushed
the
surya/aorta-mn-02-single-node-fixes
branch
from
September 10, 2026 23:13
0feffb5 to
1b24fe6
Compare
speriaswamy-amd
removed this pull request from stack #333
September 11, 2026 00:23
speriaswamy-amd
added this pull request to stack #414
September 11, 2026 00:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 2/6 — splits #171. Base: #326.
Why
Two defects on the existing single-node path, both surfaced by live 2-node validation but neither multi-node specific.
_launch_container()never passeduser, so the container ran as the image's default UID (jenkinson the validation cluster) and could not open/dev/kfddespite--privileged. Therendergroup was also missing. The function's own comment already claimed "Run as root so the container can access GPUs" — the code now matches it.--override k=v --override k2=v2. Aorta'strain.pydeclares--overridewithnargs="*", so argparse keeps only the last group — every preceding override was silently dropped.What changed
cvs/runners/aorta.py—user="root",group_add=["video", "render"]; allkey=valuetokens packed behind a single--override.run()into_build_base_env()so the override packing is unit-testable without a container.Test
ruffclean. Unit tests 589 → 595 (6 new: env construction, single---overrideinvariant, container user/groups).