feat(vllm): report threshold gates as metric subtests - #389
Merged
Merged
Conversation
atnair-amd
force-pushed
the
atnair/vllm-config-refactor
branch
from
September 9, 2026 18:32
b8064cb to
b551428
Compare
added 2 commits
September 9, 2026 15:31
Keep HTML reports readable by collapsing one-row-per-metric tests into a per-cell verification parent with pass/fail/skip subtests.
atnair-amd
force-pushed
the
atnair/vllm-metric-subtests
branch
from
September 9, 2026 22:34
5a5a205 to
b6863f7
Compare
Collaborator
|
LGTM Instead of one pytest row per metric, there’s now one verification test per cell. the actual gates show up as subtests (pass/fail/skip). if thresholds aren’t being enforced, it just records the numbers in the html and skips instead of marking them as passed. |
hnimra-amd
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_verify_cell_metricsso each cell reports active threshold gates as pass/fail/skip subtests.Test plan