Skip to content

Turn on ROBOT's label_formatting check - #20

Open
hoodcm wants to merge 1 commit into
mainfrom
robot-label-formatting
Open

hoodcm wants to merge 1 commit into
mainfrom
robot-label-formatting

Conversation

@hoodcm

@hoodcm hoodcm commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Part of #5.

Check Data checked Why
label_formatting Labels A label has no line break or tab.

ROBOT's standard check, at its default level (ERROR). Nothing on main fails it, so no data changes. All tests pass.

@jclerman

jclerman commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

For future-us: The behavior of ROBOT's checks is documented here.

@jclerman
jclerman self-requested a review October 1, 2026 21:41

@jclerman jclerman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I think we might want to apply this requirement to several name/synonym annotation properties, so we might be better-served with a custom test that looks like https://robot.obolibrary.org/report_queries/label_formatting but binds more annotation properties. However, that can be a future improvement; the PR as-is already improves over what we have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants