Conversation
…d check that each has one (#13)
…lete class carries
jclerman
reviewed
Oct 1, 2026
| WHERE { | ||
| ?entity rdfs:subClassOf+ rid:RID15849 . | ||
| FILTER NOT EXISTS { ?entity rdfs:label ?label . FILTER(LANG(?label) = "en") } | ||
| BIND(rdfs:label AS ?property) |
Collaborator
There was a problem hiding this comment.
Alternative pattern for this that is easily extended to cover more properties later (totally optional here):
Suggested change
| BIND(rdfs:label AS ?property) | |
| VALUES ?property { rdfs:label } |
jclerman
reviewed
Oct 1, 2026
| SELECT ?entity ?property ?value | ||
| WHERE { | ||
| ?entity rdfs:subClassOf+ rid:RID15849 . | ||
| FILTER NOT EXISTS { ?entity rdfs:label ?label . FILTER(LANG(?label) = "en") } |
Collaborator
There was a problem hiding this comment.
I would move this line down below the BIND (or VALUES) line, and then replace rdfs:label here with ?property. That eliminates repetition, so the two can't get out of sync.
jclerman
reviewed
Oct 1, 2026
| FILTER NOT EXISTS { ?entity rdfs:label ?label . FILTER(LANG(?label) = "en") } | ||
| BIND(rdfs:label AS ?property) | ||
| OPTIONAL { ?entity rid:Preferred_Name_for_Obsolete ?name } | ||
| BIND(COALESCE(STR(?name), "") AS ?value) |
Collaborator
There was a problem hiding this comment.
The offending "value" is actually the lack of a value. I would drop the reference to the obsolete name and simply bind "" here (or some sentinel value that we treat as None - it doesn't really matter since it's the ?entity ?property combination that defines where there's an issue).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #13.
I added one check.
I gave 912 obsolete classes an English label from their obsolete name:
RID32059's label changed from "pre-aortic lymph node group proper," which is another obsolete class's name, to its own name, "pre-aortic proper lymph node."
Two of the 912, RID27787 and RID49508, are the classes PR #9 files under RID15849.
Preferred_Name_for_Obsoletestays for now. A later PR removes it, after the reason-for-deprecation property is named.ROBOT's
missing_labeldrops from 972 to 67. All tests pass.