fix(q): validate handles and wire protocol frames - #10
Open
belowzeroff wants to merge 3 commits into
Open
belowzeroff wants to merge 3 commits into
belowzeroff wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes for users
Invalid Q client arguments now fail before touching the socket:
.q.connectrejects malformed credential/timeout/port values,.q.sendand.q.closereject values that are not live non-negative i64 handles, and invalid close handles return an error instead of silently succeeding.Malformed or hostile wire input is rejected safely: invalid table markers, unsupported handshake capability bytes, oversized compressed frames, and unknown message types no longer get accepted or evaluated.
Validation
make recheck RAYFORCE_LOCAL_PATH=/home/athuser/rayforce-build/rayforce-core-Wall -Wextra -WerrorAll checks pass.