fix(value): guard collection access on atoms - #10
Open
belowzeroff wants to merge 1 commit into
Open
belowzeroff wants to merge 1 commit into
belowzeroff wants to merge 1 commit into
Conversation
belowzeroff
force-pushed
the
fix/value-collection-access
branch
from
September 18, 2026 18:31
e5ea748 to
b15737d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Guard collection-only accessors before calling vector/list FFI paths:
Value::get(idx)now returns a binding error when called on a non-vector/non-list value.Value::is_null_at(idx)now returnsfalsefor non-vectors and out-of-range indexes before callingray_vec_is_null.User-visible bug
These are safe Rust APIs, so calling them on an atom should not reach C functions that expect vector/list layout.
Before this change, code like this could treat an atom as if it had collection storage:
After this change:
This keeps the existing
is_null_atsignature, avoiding an API break, while making the FFI boundary total for non-vector values.Tests
collection_access_rejects_atomsregression coverage.cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningsenv RUST_TEST_THREADS=1 cargo test --workspace