perf(aggr): scale grouping across aggregate families - #540
Merged
Merged
Conversation
Rayforce targeted audit passedThe required Rayforce audit gate passed on the latest run. Workflow run: https://github.com/RayforceDB/rayforce/actions/runs/35107326720 |
Use the equivalent atomic qualifier spelling so Cppcheck 2.13 recognizes the narrow directory pointer type. The five reported diagnostics disappear with the CI flags, and the release executable remains byte-for-byte identical with matching build metadata.
4 tasks
singaraiona
added a commit
that referenced
this pull request
Sep 17, 2026
test(group): oracles for the fixes in #540 and the coverage gaps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Grouped queries repeated key work across aggregates, duplicated large state arrays across workers, and left dominant groups or result gathering on one worker. This change shares query-local grouping and stable row layouts across aggregate families, bounds partition scratch storage, and splits large consumers into parallel stages.
The results report includes all worker counts, cold/warm timings, per-process samples, peak memory and remaining regressions. Cold setup costs and timing variation are reported explicitly; speedups vary by aggregate and key shape.
Validation
19154617.19154617, including Linux/macOS debug and release, TSan, fuzz-smoke, and static analysis.make cppcheckwith Cppcheck 2.13.0: PASS, no diagnostics.fdf365f3; restored symbol and wide count-distinct query fixtures also passed with 28 total threads.fdf365f3: 26/26 passed, four total threads, without suppressions. Earlier five-thread attempts at the original measured revision stalled in pool shutdown before aggregation and are not counted as passes.f61a4eda. Audit follow-up releasefdf365f3builds without warnings and passed 174/174 focused dense-route comparisons, including repeats of three initial slowdowns; both samples and binary hashes are retained in the report.Four baseline distinct cases fail to execute correctly and receive no speedup claim. Their candidate results are checked across workers and against independent unit oracles.
8ab7c40f: clean release builds without warnings; 130/130 ASan/UBSan tests and 41/41 parallel TSan tests passed after fixing two races exercised by the restored query fixture.Audit fixes
_Atomic TYPE*declaration form in the five shared-directory macros. Cppcheck 2.13.0 reproduces the five pointer-to-integer diagnostics on the original code and reports none on the fixed file with CI flags. With matching build metadata, the release executable is byte-for-byte identical. Full local and hosted static analysis both passed on19154617.Checklist
dev