Skip to content

fix(system): reject boolean timeit arguments - #614

Closed
belowzeroff wants to merge 1 commit into
RayforceDB:devfrom
belowzeroff:fix/system-timeit-bool-validation
Closed

belowzeroff wants to merge 1 commit into
RayforceDB:devfrom
belowzeroff:fix/system-timeit-bool-validation

Conversation

@belowzeroff

Copy link
Copy Markdown
Contributor

What changes for users

.sys.timeit true and .sys.timeit false now return a type error instead of silently toggling the profiler. Numeric integer arguments and strict numeric strings keep their existing behavior.

Why

Boolean values are distinct from integer values in Rayfall and should not be accepted by the integer argument parser used by .sys.timeit and .sys.listen.

Validation

  • Targeted rfl/system/syscmd_coverage: 1/1 passed
  • Full test suite: 3928/3928 passed
  • Release build with -Werror: passed
  • Based on fresh origin/dev (d13bde4c)

@singaraiona

Copy link
Copy Markdown
Collaborator

No, the should be accepted by design.

@belowzeroff

Copy link
Copy Markdown
Contributor Author

The current dev branch intentionally keeps boolean .sys.timeit arguments supported, so this change is obsolete and has no remaining patch to carry. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants