Skip to content

Workspace is a page at /workspace, not an overlay - #1141

Merged
yattias merged 1 commit into
mainfrom
ai-mode-workspace/workspace-page
Oct 8, 2026
Merged

yattias merged 1 commit into
mainfrom
ai-mode-workspace/workspace-page

Conversation

@yattias

@yattias yattias commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

The workspace stops being a full-screen overlay opened with ?ai=1 and
becomes a page inside the app shell.

What changes

  • Left column: the logo and Publish button stay where they are on
    every page; Conversations and Drafts take the place of the nav items.
    The "+ New RFP / New proposal" button is gone, since Publish starts a
    new one and lets you pick which.
  • Main area: the app's top bar reads "← Workspace", with the
    workspace strip (open title, publish controls) under it. Chat and
    document fill the rest, edge to edge.
  • URL: /workspace?chat=12, ?note=34&chat=12&view=chat, and
    ?new=rfp or ?new=proposal for the start screen, so the side
    survives a reload. Old ?ai=1 links redirect.
  • History: opening conversations and drafts replaces the URL. Back,
    or the top bar's arrow, leaves in one step.
  • Widths: 240px column from 1240px up. From 768 to 1239px it is the
    app's 70px rail and the lists open over the panes from a button in the
    strip. On a phone there is no bottom nav and no strip; the title moves
    into the chat header and the lists are a screen of their own with
    Publish on top.
  • Access: signed out goes to sign-in. A signed-in user the workspace
    does not admit sees the shell with the server's message.

PageLayout gains leftSidebarContent and fullBleed for this. The
overlay, its modal behaviour hook, and two props and a callback only it
used are removed.

Checked

Type-check, eslint and prettier. With the smoke account in Playwright at
1440, 1024 and 390px: the Publish menu, New proposal and a draft card
each land on the right URL; the first message turns ?new=proposal into
?chat=<id> without a history entry; Back returns to My Funding in one
step; an old ?ai=1&aiChat=5 link ends on /workspace?chat=5; the
not-admitted message shows when the conversations list answers 403.

Not checked

  • Publishing from the workspace end to end (it would create a real RFP).
    The change there is one removed callback before the existing redirect.
  • The assistant's reply: the local backend failed the test turn with
    "The agent could not complete this request", as it does for an older
    conversation there.

Stack

Part of turning the AI Mode overlay into a funding workspace (plan and mock decisions in the first PR's thread). Stacked on #1126; merge that first, then this one.

  1. Wrapping AIMode and notebook with publishing provider #1116
  2. Replace the AI Mode document tabs with detail blocks and header publish controls #1118
  3. Share one chat session between the AI Mode overlay and the notebook panel #1117
  4. Start a workspace conversation by saying whether you fund or need funding #1119
  5. Lift the notebook's note listing into a hook and name a note's kind #1120
  6. Break the AI Mode overlay into a shell, a sidebar and the panes #1121
  7. Open documents in the workspace, with a chat on each that is kept once used #1122
  8. Give phones a full-screen view of conversations and documents #1123
  9. Workspace review fixes: one-line sidebar rows, no layout toggle, no notebook link #1124
  10. Open the workspace from the nav and top bar, and name it Workspace #1125
  11. Enter the workspace from Publish and My Funding; drafts and published work as rows #1126
  12. Workspace is a page at /workspace, not an overlay #1141
  13. The document heads with a byline, and Publish asks for the rest in a dialog #1142

🤖 Generated with Claude Code

@yattias
yattias requested a review from a team as a code owner October 5, 2026 18:03
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@vercel

vercel Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
web Ready Ready Preview Oct 8, 2026 2:48pm UTC

Request Review

Conversations and drafts take the nav's place in the left column, and
the chat and document fill the rest. Old ?ai=1 links redirect.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@yattias
yattias force-pushed the ai-mode-workspace/start-screen-polish branch from 73356ee to fd4fcf8 Compare October 8, 2026 14:46
@yattias
yattias force-pushed the ai-mode-workspace/workspace-page branch from bdfd563 to d5671a4 Compare October 8, 2026 14:46
@sonarqubecloud

sonarqubecloud Bot commented Oct 8, 2026

Copy link
Copy Markdown

@yattias
yattias removed this pull request from stack #1146 October 8, 2026 15:07
Base automatically changed from ai-mode-workspace/start-screen-polish to main October 8, 2026 15:29
@yattias
yattias merged commit d5671a4 into main Oct 8, 2026
4 of 6 checks passed
@yattias
yattias deleted the ai-mode-workspace/workspace-page branch October 8, 2026 15:29

This branch was successfully deployed

1 active deployment
Preview — d5671a4a Deployed Oct 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant