Repository navigation
Remove import-free files, duplicate analytics wiring and eight unused dependencies - #1164
Merged
Merged
Conversation
… dependencies First chunk of the dead-code plan. Everything here was imported by nothing (knip plus an independent import-graph scan, cross-checked by grep on the current main). - Two empty files, the Tiptap template leftovers (Pages-router files inside components/Editor, the *Free AI stubs, useSidebar/SidebarContext, five unused barrels) and the nested app/notebook/robots.ts that Next.js never reads. - The older Amplitude service and the two providers that were never mounted; analytics.service.ts is the live path. - Unused UI, modals, icons, feed, profile, expert-finder and store/service files, types/audit.ts and the audit helpers only it used, and ChangelogLink.tsx, which lost its last importer in the sidebar footer merge. - Dependencies nothing resolves: ogl, tailwindcss-animate, @tailwindcss/typography, autoprefixer, @eslint/eslintrc and three @types packages for libraries that ship their own types. - tsconfig no longer excludes a file that does not exist; .env.example drops two variables nothing reads; two commented-out blocks go. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
It only reached node_modules through @types/react-datepicker, which the previous commit removed, so /peer-review, /journal and anything else rendering FundingProposalCard failed to compile with "Can't resolve 'date-fns'". Pinned to the 3.x line that was already installed; a bump to 4.x (which react-datepicker 8 nests its own copy of) is a separate change. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First chunk of the dead-code removal plan (
docs/dead-code-report.md, kept local). Everything removed here was imported by nothing: found with knip 5 plus an independent import-graph scan, then each file was grepped for its basename to rule out dynamic imports and string references, and re-checked against today'smain.What goes
RequestFundingModal.tsx,VoteButton.tsx(0 bytes each).components/Editor/pages, the*FreeAI stubs,useSidebar/SidebarContext, five barrels nobody imports, andapp/notebook/robots.ts(onlyapp/robots.tsis a metadata file, so this never ran).amplitude.service.tsandAmplitudeProvider, andAnalyticsProvider, which was never mounted.analytics.service.tsis the live path and is untouched.RSCBadgeExamples, feed and notification leftovers,ReleaseNotesModal,ShareModalTrigger, profile About pieces, expert-finder reply-to files,journal.service.ts,hubStore.ts,types/audit.tsand the four audit helpers only it called,avatarUtil,dateUtils.ChangelogLink.tsx, which lost its last importer in the "Help & resources" sidebar merge (Recently visited shows pictures, and the sidebar footer is one Help & resources menu #1150-era) after the scan.ogl(only Aurora used it),tailwindcss-animateand@tailwindcss/typography(no Tailwind plugins are registered),autoprefixer(not inpostcss.config.mjs),@eslint/eslintrc(flat config), and@types/qrcode.react,@types/react-datepicker,@types/react-avatar-editor(those libraries ship their own types). Removed withnpx -y npm@10.7.0 uninstall.date-fns: five files import it directly, but it only reachednode_modulesthrough@types/react-datepicker. Without the declaration/peer-review,/journaland anything else renderingFundingProposalCardfails to compile. Pinned to the 3.x line that was already installed. (highlight.js,@radix-ui/react-portal,@tanstack/react-queryandwagmiare in the same situation but still resolve today; declaring them is a follow-up.)tsconfig.jsonno longer excludes a file that does not exist;.env.exampledrops two variables nothing reads; two commented-out blocks inhooks/useTip.tsandnext.config.js.63 files deleted, 4156 lines removed (lockfile included); no behaviour change intended.
Checks
npm run lint: 0 errors (2 pre-existing warnings in untouched files)npm run type-check: cleanNext
Chunk 2 (
cleanup/2-funding-wallet-files) follows once this is merged.🤖 Generated with Claude Code