Repository navigation
Retire the paper pages - #1179
Merged
Merged
Conversation
Seventh chunk of the dead-code plan: paper pages are no longer part of the product. - /paper and /paper/:path* redirect permanently to the homepage. The seven registered-report entries that map old paper URLs to /report stay ahead of the catch-all, so those links still land on the report. - app/paper goes (the slug and DOI redirect pages, the layout and the five tab pages), and with it the paper feed card, the journal and hashtag badges only it rendered, the paper header skeleton, the hot-score tooltip, the version-history tab and its display (versions were a paper feature), PaperService's metadata/abstract updaters and the OpenAlex creator, and the paper sitemap chunk. Two leftovers from main's earlier removals go in the same sweep: services/file.service.ts and components/ui/MainPageHeader. - buildWorkUrl no longer builds paper URLs: a paper (and any unknown content type) gets '#', which the mention renderers, the recently-visited rail and the activity cards already treat as "no link". The DOI argument only ever served paper URLs, so it goes. - The frontend stops rendering paper entries: FeedEntryItem returns nothing for a PAPER entry and the activity feed builds no work card for a paper event. Bounties and comments on papers still show, with no destination for the paper itself. - The search handlers keep routing recent and OpenAlex "paper" suggestions: proposals and posts go to their pages, papers go home. - The top bar, back-navigation list, share-title label, ESLint page glob and lint:work-pages script drop their paper entries. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Seventh chunk of the dead-code removal plan (
docs/dead-code-report.md, kept local), following #1174: paper pages are no longer part of the product.Redirects
/paperand/paper/:path*redirect permanently to the homepage. The seven registered-report entries that map old paper URLs to/report/...stay ahead of the catch-all, so those links still land on the report. Verified on the dev server:/paper,/paper/:id,/paper/:id/:slug, a tab URL and/paper?doi=all answer 308 to/; the registered-report URL still answers 308 to its/reportpage.What goes
app/paper/**(the slug and DOI redirect pages, the layout and the five tab pages) and everything only it reached: the paper feed card, the journal and hashtag badges only that card rendered, the paper header skeleton, the hot-score tooltip, the version-history tab and its display (versions were a paper feature),PaperService's metadata/abstract updaters and the OpenAlex creator (PaperService.getstays for the expert finder), and the paper sitemap chunk.main's earlier removals, swept up here:services/file.service.tsandcomponents/ui/MainPageHeader.tsx.lint:work-pagesscript drop their paper entries.How the rest of the app treats papers now
This is the frontend side of the open question in the plan; it needs no backend change.
buildWorkUrlno longer builds paper URLs: a paper (and any unknown content type) gets'#', which the comment mention renderers, the recently-visited rail and the activity cards already treat as "no link". The DOI argument only ever served paper URLs, so it goes.FeedEntryItemreturns nothing for aPAPERentry and the activity feed builds no work card for a paper event, so paper cards disappear from every feed, list and profile tab that renders feed entries.If the backend later stops emitting paper entries, the
PAPERguards become dead and can go.39 files changed, 1,244 lines removed, 42 added. The remaining behaviour changes are the ones listed above.
Checks
npm run lint: 0 errors (2 pre-existing warnings in untouched files)npm run type-check: cleanNext
Chunk 8 (
retire/8-notebook) is the last page retirement and the biggest; its prerequisites table in the plan lists the workspace doors that have to exist first.🤖 Generated with Claude Code