Repository navigation
Conversation
Eighth and last chunk of the dead-code plan. Drafting, editing and publishing live in the workspace now, so the notebook pages, the note and organization invite pages and everything only they reached go. Redirects: /notebook opens the workspace; /notebook?newGrant and ?newFunding open its new-RFP and new-proposal screens; /notebook/<org>/<id> opens that document (/workspace?note=<id>); the invite URLs land on the workspace too. Doors that pointed into the notebook now point into the workspace: editing a published work from its header menu, "Draft new" and "Continue with draft" in the apply-to-RFP modal, the expert finder's proposal draft, the registered-report moderation draft, the referral page's Create proposal button, and the landing footer's link (now "Workspace"). A proposal started from the apply modal no longer carries the chosen RFP in the URL; it is picked in the workspace masthead instead. Moderators keep their ChangeLog door: the Publish menu shows them a ChangeLog item that creates a DISCUSSION draft from the standard template and opens it in the workspace, where the publish flow already treats changelog notes as moderator-only. The published post's id still goes into CHANGELOG_POST_IDS by hand, as before. Dropped with the notebook, per the decisions on the plan: Word/Markdown document upload (its convert route, Tiptap import extension, JWT signing and the Tiptap env variables), organization switching and invites (notes keep belonging to the user's default organization; the organization service keeps only the listing the context reads), the legacy-note banner, and the notebook-only chat panel pieces. The publishing form the notebook's Details tab rendered goes too; the workspace's publish dialog only reads the help text, option lists and hooks from those files, which stay. KaTeX's stylesheet moves from the notebook layout to the root layout so math keeps rendering wherever a document shows. The Inter font package served no stylesheet that referenced it and is removed. The smoke specs that drive the notebook are left as they are for now. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eighth and last chunk of the dead-code removal plan (
docs/dead-code-report.md, kept local), following #1180. Drafting, editing and publishing live in the workspace now, so the notebook pages, the note and organization invite pages, and everything only they reached go.Redirects
/notebook/workspace/notebook?newGrant=…/workspace?new=rfp/notebook?newFunding=…/workspace?new=proposal/notebook/<org>/workspace/notebook/<org>/<id>/workspace?note=<id>/note/join/<key>,/org/join/<token>/workspaceAll verified on the dev server (307s; Next carries the old query string along, which the workspace ignores). The three query-aware entries come before the plain
/notebookone, as Next matches in order.Doors repointed into the workspace
/workspace?note=<id>)Decisions carried out
useChangelogDrafting) that creates a DISCUSSION draft from the standard template and opens it in the workspace. The publish provider already treats changelog notes as moderator-only and labels them "ChangeLog entry"; the article type comes from the note's document type, so no query flag is needed. As before, the published post's id goes intoCHANGELOG_POST_IDSby hand. The draft is not listed in the sidebar's Drafts (that list is RFPs and proposals), so it is written and published in one sitting or reopened by URL.OrganizationServicekeeps only the listing the context reads; the invite, member and cover-image methods, the settings modal anduseOrganizationgo.@tiptap-pro/extension-import,jsonwebtokenand the Tiptap env variables), the legacy-note banner, the notebook chat panel pieces, the grant and proposal templates (the workspace starts drafts empty), and the publishing form the notebook's Details tab rendered. The workspace's publish dialog only reads the help text, option lists and hooks from those section files, which stay.smoke/rfp.spec.ts,smoke/proposal.spec.ts,smoke/helpers/notebook.ts) are left as they are for now and will fail against this branch until rewritten against the workspace.@fontsource/interis removed: no stylesheet referenced it.94 files changed, 8,456 lines removed, 158 added.
Checks
npm run lint: 0 errors (2 pre-existing warnings in untouched files)npm run type-check: cleanNot exercised here: the moderator ChangeLog door and the repointed signed-in doors (edit, apply-to-RFP, expert finder, moderation) need a signed-in session; worth a click-through on the Vercel preview.
🤖 Generated with Claude Code