Skip to content

feat(tickets): warn reporters when logic changed since they played - #5160

Merged
wescopeland merged 6 commits into
RetroAchievements:masterfrom
wescopeland:ticket-changed-logic-warning
Sep 4, 2026
Merged

feat(tickets): warn reporters when logic changed since they played#5160
wescopeland merged 6 commits into
RetroAchievements:masterfrom
wescopeland:ticket-changed-logic-warning

Conversation

@wescopeland

Copy link
Copy Markdown
Member

Resolves #5106.

The ticket creation form will now warn the user if logic has changed since their play session. Additionally, the ticket details page shows which logic version was current when the ticket was filed.

Screenshot 2026-08-09 at 5 05 48 PM Screenshot 2026-08-09 at 5 06 28 PM Screenshot 2026-08-09 at 5 08 53 PM

@wescopeland
wescopeland requested a review from a team August 9, 2026 21:15
@greptile-apps

greptile-apps Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds logic-change warnings and records trigger versions on unlocks and tickets.

  • Resolves session-time trigger versions for new unlocks.
  • Warns reporters when achievement logic changed.
  • Displays filing and current logic versions on tickets.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Reviews (4): Last reviewed commit: "fix: address feedback" | Re-trigger Greptile

Comment thread app/Platform/Actions/UnlockPlayerAchievementAction.php
Comment thread app/Platform/Actions/UnlockPlayerAchievementAction.php
Comment thread app/Platform/Actions/UnlockPlayerAchievementAction.php
Comment thread app/Platform/Actions/BuildTicketCreationDataAction.php
@wescopeland
wescopeland enabled auto-merge (squash) September 4, 2026 18:20
@wescopeland
wescopeland merged commit f632a16 into RetroAchievements:master Sep 4, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warn ticket reporters when logic has changed since their play session

2 participants