fix: correct game forum resource URL encoding (#3339) - #5199
Open
adamjohnny5 wants to merge 2 commits into
Open
Conversation
Contributor
Greptile SummaryCorrects resource search URL encoding using Confidence Score: 5/5Safe to merge; restoring regression coverage is recommended. Encoding is correct, but its focused regression test was removed. Files Needing Attention: app/Helpers/database/forum.php Reviews (2): Last reviewed commit: "fix: correct game forum resource URL enc..." | Re-trigger Greptile |
wescopeland
reviewed
Sep 4, 2026
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes URL issues in official game forum topics involving titles with apostrophes or other reserved characters. The changes replace manual escaping with proper query encoding, add regression coverage for special characters, and ensure external search URLs preserve the full game title.
Testing included targeted backend coverage for the affected flow,
composer fix,composer analyse, and manual review of the generated resource URLs.