Skip to content

Improve hf mf gdm* commands - #3493

Open
0x6r1an0y wants to merge 6 commits into
RfidResearchGroup:masterfrom
0x6r1an0y:20260819-gdmfix
Open

Improve hf mf gdm* commands#3493
0x6r1an0y wants to merge 6 commits into
RfidResearchGroup:masterfrom
0x6r1an0y:20260819-gdmfix

Conversation

@0x6r1an0y

@0x6r1an0y 0x6r1an0y commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Fix #3458.

  • Every hf mf gdm* command now probes the card and picks a working access path. Passing --gdm/--gen1a/--wupa explicitly keeps the previous single-attempt behavior.

  • gdmwipe could flip the wakeup style in the middle of the command, causing every subsequent block write to fail with wupGDM1 error.

  • gdmwipe never checked block write status, so a wipe that wrote nothing still reported "Wipe completed!". Failures are now counted and reported.

  • --wakestyle <gdm|gen1a|off> in gdmsetcfg is now the single backdoor control, and the overlapping --gen1 <on|off> is removed. This also clears up the naming confusion between --gen1 and --gen1a. The help now makes the distinction clear with the access: prefix for wakeup flags and config: for stored config flags.

Tested all 3 wakeup methods × all 9 commands (27 combinations). All good.

@github-actions

Copy link
Copy Markdown

You are welcome to add an entry to the CHANGELOG.md as well

@0x6r1an0y 0x6r1an0y changed the title Improve hf mf gdm* commands Improve hf mf gdm* commands Aug 23, 2026
@iceman1001

Copy link
Copy Markdown
Collaborator

there is very large AI comments in this PR , we most likely don't need them, if there is need to explain something we have docs and notes to do so.

@0x6r1an0y

Copy link
Copy Markdown
Contributor Author

fixed in a1a400e

@iceman1001

Copy link
Copy Markdown
Collaborator

Don't manually edit "doc/commands.*" or pm3_vocabulary files those are automatic generated seperate

@0x6r1an0y

0x6r1an0y commented Aug 30, 2026

Copy link
Copy Markdown
Contributor Author

Roger that.
Would a short note in CONTRIBUTING.md about not hand-editing the autogenerated files (doc/commands.*, pm3line_vocabulary.h) make sense? Happy to PR it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gdmgetcfg not working on gen4 gdm card

2 participants