Improve hf mf gdm* commands - #3493
Open
0x6r1an0y wants to merge 6 commits into
Open
Conversation
… into 20260819-gdmfix
… into 20260819-gdmfix
|
You are welcome to add an entry to the CHANGELOG.md as well |
This was referenced Aug 22, 2026
Collaborator
|
there is very large AI comments in this PR , we most likely don't need them, if there is need to explain something we have docs and notes to do so. |
Contributor
Author
|
fixed in a1a400e |
Collaborator
|
Don't manually edit "doc/commands.*" or pm3_vocabulary files those are automatic generated seperate |
Contributor
Author
|
Roger that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3458.
Every
hf mf gdm*command now probes the card and picks a working access path. Passing--gdm/--gen1a/--wupaexplicitly keeps the previous single-attempt behavior.gdmwipecould flip the wakeup style in the middle of the command, causing every subsequent block write to fail withwupGDM1 error.gdmwipenever checked block write status, so a wipe that wrote nothing still reported "Wipe completed!". Failures are now counted and reported.--wakestyle <gdm|gen1a|off>ingdmsetcfgis now the single backdoor control, and the overlapping--gen1 <on|off>is removed. This also clears up the naming confusion between--gen1and--gen1a. The help now makes the distinction clear with theaccess:prefix for wakeup flags andconfig:for stored config flags.Tested all 3 wakeup methods × all 9 commands (27 combinations). All good.