fix: allow enum variants named Error - #5
Open
akselerando wants to merge 1 commit into
Open
Conversation
The generated `TryFrom<i32>` impl referred to its error type as `Self::Error`. When the enum also has a variant named `Error`, this reference is ambiguous and triggers the `ambiguous_associated_items` lint, which is deny-by-default and will become a hard error (rust-lang/rust#57644). Fully qualify the reference as `<Self as TryFrom<i32>>::Error` instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If an enum has a variant named
Error,Self::Errorbecomes ambiguous since both the enum variant and the associated type are named the same.See also: https://doc.rust-lang.org/rustc/lints/listing/deny-by-default.html#ambiguous-associated-items
Solution
Fully type out the error type to avoid ambiguity
Full disclosure: this problem was debugged with AI and the solution was partially implemented using Claude