Fix 2 Mbaud serial configuration on Linux with MUSL - #15
Open
reinauer wants to merge 1 commit into
Open
Conversation
DrawBridge configures its serial connection at 2,000,000 baud. The Unix fallback passed that numeric value directly to cfsetspeed(). Raw baud values are not portable speed_t values. musl rejects them, and binaries linked to cfsetspeed@GLIBC_2.2.5 can receive EINVAL when run with newer glibc termios compatibility code. Translate 2000000 to B2000000 before calling cfsetspeed(), and fail cleanly on platforms that do not provide that constant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DrawBridge configures its serial connection at 2,000,000 baud. The Unix
fallback passed that numeric value directly to cfsetspeed().
Raw baud values are not portable speed_t values. musl rejects them, and
binaries linked to cfsetspeed@GLIBC_2.2.5 can receive EINVAL when run
with newer glibc termios compatibility code.
Translate 2000000 to B2000000 before calling cfsetspeed(), and fail
cleanly on platforms that do not provide that constant.