Fix world-to-camera transforms in flow keyframing - #106
Open
zjn20030811 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
E_cur^-1and reproject them withE_kfRoot cause
pose_encoding_to_extri_intrireturns OpenCV world-to-camera extrinsics, but the flow-keyframe code treated the current extrinsic as camera-to-world and inverted the keyframe extrinsic. It therefore evaluatedinstead of the required relative transform
This affects both streaming and windowed keyframe selection paths in
gct_stream_window.pyandgct_stream_window_v2.py.The regression uses a 24x40 image,
fx != fy, different current/keyframe intrinsics, rotation, translation, and varying depth. The direct homogeneous-projection reference is4.492928 px; both fixed production implementations return4.492928 px, while the previous inverse convention returns6.628602 px. This crosses the 5-pixel flow threshold and changes the keyframe decision.Validation
python -m pytest -q— 2 passedpython -m compileall -q lingbot_map testsgit diff --check