Preserve per-frame intrinsics in camera conditioning - #65
Open
zjn20030811 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fx,fy,cx, andcyinstead of repeating the first calibration across every latent frameMotivation
The documented camera-control input contains one
[fx, fy, cx, cy]row per frame. Both inference paths currently reduce that array toKs[0]before constructing ray/Plücker conditioning, so zoom or other dynamic calibration is lost while the pose remains time-varying.The included
examples/01sequence has 561 per-frame rows and roughly a 29-pixel focal-length range. Repeating its first row changes the resulting edge rays by up to about 1.52 degrees. This patch aligns calibration and pose on one shared source/target grid before ray construction.Compatibility
Validation
python -m pytest tests/test_cam_utils.py -q— 13 passedpy_compile, andgit diff --check