Skip to content

refactor: delete unused Driver messages and joinedIds fields - #434

Open
arbazkhan971 wants to merge 1 commit into
RocketChat:mobilefrom
arbazkhan971:refactor-delete-unused-driver-fields
Open

arbazkhan971 wants to merge 1 commit into
RocketChat:mobilefrom
arbazkhan971:refactor-delete-unused-driver-fields

Conversation

@arbazkhan971

Copy link
Copy Markdown

Summary

Deletes the unused messages and joinedIds fields from Driver and IDriver.

messages was never assigned, so it stayed undefined. Subscription de-duplication already lives on the Socket, keyed by stream name. joinedIds was initialized to [] and never written or read. Both were public, so they looked like real driver state.

Test plan

  • npx tsc --noEmit
  • npm run lint
  • npx jest lib/drivers consumer (313 tests)

Fixes #379

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: delete the unassigned messages and joinedIds fields on Driver

2 participants