Skip to content

refactor: delete unused replaceLog and silence helpers - #435

Open
arbazkhan971 wants to merge 1 commit into
RocketChat:mobilefrom
arbazkhan971:refactor-delete-unused-log-helpers
Open

arbazkhan971 wants to merge 1 commit into
RocketChat:mobilefrom
arbazkhan971:refactor-delete-unused-log-helpers

Conversation

@arbazkhan971

Copy link
Copy Markdown

Summary

Deletes replaceLog and silence from lib/log.ts.

Neither had a caller in shipped source, and index.ts does not re-export them. The SDK already injects a logger per Api / Driver instance. The default logger stays silent, and warn still forwards to warning (now covered by a unit test).

Test plan

  • npx tsc --noEmit
  • npm run lint
  • npx jest lib/__tests__/log.spec.ts

Fixes #380

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: delete the unused replaceLog and silence exports from lib/log.ts

2 participants