Skip to content

Deprecate and remove findStateAtEvent method in StateService #254

Description

@coderabbitai

Description

The findStateAtEvent method in StateService is marked with a TODO comment indicating it should be removed.

Location: packages/federation-sdk/src/services/state.service.ts (around line 897)

Current State

The method is marked with // TODO: remove this and currently wraps getStateAtEvent.

Suggested Migration Path

  1. Add a JSDoc @deprecated annotation to the method pointing users to getStateAtEvent
  2. Identify and migrate all callers to use getStateAtEvent directly
  3. Remove commented-out tests in state.service.spec.ts that reference this TODO
  4. Remove the method once all migrations are complete

Context

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions