Skip to content

feat(federation-sdk): export PduSchema - #412

Open
devendrakushwah80 wants to merge 1 commit into
RocketChat:mainfrom
devendrakushwah80:expose-pdu-schema
Open

devendrakushwah80 wants to merge 1 commit into
RocketChat:mainfrom
devendrakushwah80:expose-pdu-schema

Conversation

@devendrakushwah80

@devendrakushwah80 devendrakushwah80 commented Sep 13, 2026

Copy link
Copy Markdown

Summary

Export PduSchema from @rocket.chat/federation-sdk.

This makes the room PDU schema available to downstream consumers without requiring a direct dependency on @rocket.chat/federation-room.

Motivation

Rocket.Chat currently has a TODO in the Matrix federation invite endpoint to use the room PDU schema for validating the event payload:

RocketChat/Rocket.Chat#42111

Since @rocket.chat/federation-room is a workspace package and is not published independently for external consumption, exposing PduSchema through the federation SDK provides a stable public entry point for consumers such as Rocket.Chat.

Validation

  • bun run build — all 6 workspace packages passed
  • bun test in packages/federation-sdk — 75 passed, 0 failed

Review in cubic

Summary by CodeRabbit

  • New Features
    • Added PduSchema to the federation SDK’s public exports, making it available alongside the existing federation schemas and ID utilities.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 941299e2-5a81-4cac-876a-8e6150ed88b9

📥 Commits

Reviewing files that changed from the base of the PR and between 9e36970 and b17565b.

📒 Files selected for processing (1)
  • packages/federation-sdk/src/index.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: cubic · AI code reviewer
🔇 Additional comments (1)
packages/federation-sdk/src/index.ts (1)

80-80: LGTM!


Walkthrough

The federation SDK now re-exports PduSchema from @rocket.chat/federation-room.

Changes

Federation SDK

Layer / File(s) Summary
Public PDU schema export
packages/federation-sdk/src/index.ts
Adds the public PduSchema export. Existing exports remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Feature

Suggested labels: type: feature

Suggested reviewers: sampaiodiego

Merge Risk: ⚪ Minimal · up to b1756

This change only exposes an existing schema through the SDK; builds and tests pass, so no merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: exporting PduSchema from federation-sdk.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI

Warning

Some tools did not complete. Review the errors below.

🔧 Biome (2.5.10)
packages/federation-sdk/src/index.ts

Biome could not lint this file: configuration resulted in errors. Check the repository's Biome configuration and plugins.

Warning

Errors were encountered while retrieving linked issues.

Errors (1)
  • JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants