feat(federation-sdk): export PduSchema - #412
devendrakushwah80 wants to merge 1 commit into
Conversation
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
🔇 Additional comments (1)
WalkthroughThe federation SDK now re-exports ChangesFederation SDK
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Feature Suggested labels: Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change only exposes an existing schema through the SDK; builds and tests pass, so no merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Warning Some tools did not complete. Review the errors below. 🔧 Biome (2.5.10)packages/federation-sdk/src/index.tsBiome could not lint this file: configuration resulted in errors. Check the repository's Biome configuration and plugins. Warning Errors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Export
PduSchemafrom@rocket.chat/federation-sdk.This makes the room PDU schema available to downstream consumers without requiring a direct dependency on
@rocket.chat/federation-room.Motivation
Rocket.Chat currently has a TODO in the Matrix federation invite endpoint to use the room PDU schema for validating the
eventpayload:RocketChat/Rocket.Chat#42111
Since
@rocket.chat/federation-roomis a workspace package and is not published independently for external consumption, exposingPduSchemathrough the federation SDK provides a stable public entry point for consumers such as Rocket.Chat.Validation
bun run build— all 6 workspace packages passedbun testinpackages/federation-sdk— 75 passed, 0 failedSummary by CodeRabbit
PduSchemato the federation SDK’s public exports, making it available alongside the existing federation schemas and ID utilities.