Skip to content

[Refactor]: 무기 강화 및 각성 재화 사용하도록 수정 - #58

Merged
movingfrog merged 5 commits into
developfrom
Refactor-EquipmentManager
Jul 9, 2026
Merged

movingfrog merged 5 commits into
developfrom
Refactor-EquipmentManager

Conversation

@movingfrog

Copy link
Copy Markdown
Contributor

개요

무기의 각성 및 강화를 할 떄 재화를 사용하도록 수정하였습니다

수정 사항

  1. 무기 강화 재화 사용
  2. 무기 각성 재화 사용
  3. 무기 Text -> TMP_Text로 변경

버그 수정

  • 무기 획득과는 관계없이 버튼 누를 수 있는 버그 수정
  • 합성과 각성 무기 선택이 이상하던 문제 해결

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the equipment system by integrating currency consumption (Upgrade Scrolls and Mithril) for weapon upgrades and awakenings, migrating UI text elements to TextMeshPro, and adding safety checks to slot interactions. The review feedback highlights several critical issues: a bug where upgrade scrolls are consumed even if the weapon is already at max level, an incorrect level offset in scroll cost calculations that allows free initial upgrades, and a bulk awakening exploit where only a single level's Mithril cost is charged. Additionally, it is recommended to use a try-finally block when temporarily modifying ScriptableObject states to prevent permanent data corruption, and to fix a typo in the slot refresh method name.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread Fantasy-Grower/Assets/Scripts/Equipment/EquipmentManager.cs
Comment thread Fantasy-Grower/Assets/Scripts/Equipment/EquipmentManager.cs Outdated
Comment thread Fantasy-Grower/Assets/Scripts/Equipment/EquipmentManager.cs
Comment thread Fantasy-Grower/Assets/Scripts/Equipment/EquipmentManager.cs Outdated
Comment thread Fantasy-Grower/Assets/Scripts/Equipment/UI/EquipmentUIManager.cs
Comment thread Fantasy-Grower/Assets/Scripts/Equipment/UI/EquipmentUIManager.cs Outdated
@movingfrog
movingfrog merged commit 796cf9e into develop Jul 9, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants