Skip to content

[Fix] - equipmentUI 부분 오류 수정 - #62

Merged
movingfrog merged 3 commits into
developfrom
Fix-EquipmentUIError
Jul 9, 2026
Merged

movingfrog merged 3 commits into
developfrom
Fix-EquipmentUIError

Conversation

@movingfrog

Copy link
Copy Markdown
Contributor

개요

장비 UI 부분에 있던 오류를 수정하였습니다

수정 사항

  • EqupmentManager와 EventSystem 삭제 및 EquipmentManager를 Prefab화
  • 불필요한 RacastTarget설정 해제

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several UI and manager updates, including the addition of the EquipManager prefab, adjustments to skill ranges in asset files, and robust binding of EquipmentManager to GameManager to handle player changes. It also adds defensive null checks and initialization logic in UI slot scripts (SelectSlot.cs, Slot.cs) to prevent runtime errors. The review feedback highlights a potential memory leak in EquipmentManager.cs due to Unity's overloaded == operator on destroyed objects, suggesting the use of ReferenceEquals. Additionally, it recommends moving icon assignment in Slot.cs to RefreshIcon() to avoid initialization order issues, and points out a redundant null check in EquipmentManager.cs.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread Fantasy-Grower/Assets/Scripts/Equipment/EquipmentManager.cs
Comment thread Fantasy-Grower/Assets/Scripts/Equipment/UI/Slot.cs
Comment thread Fantasy-Grower/Assets/Scripts/Equipment/UI/Slot.cs
Comment thread Fantasy-Grower/Assets/Scripts/Equipment/EquipmentManager.cs
@movingfrog
movingfrog merged commit 132d9cf into develop Jul 9, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants