Repository navigation
fix(ci): pin the k8s E2E cluster name (#1040) - #1042
Conversation
The CI checkout is a detached HEAD, so the branch-derived default in k3d-env.sh named the cluster "cds-head". Pin CDS_CLUSTER to "cds-k8s-e2e-ci" in the job env for attributable logs and diagnostics, and pin the invariant in test_k8s_e2e_workflow.py. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
|
RonaldHensbergen
left a comment
RonaldHensbergen
left a comment
There was a problem hiding this comment.
Self-review (contributor == reviewer), all angles checked.
Blocking: none.
Major: none.
Minor: none.
Verified beyond the diff itself:
- Runtime proof, not just green rendering: the E2E job log on this very commit shows
creating cluster cds-k8s-e2e-cianddeleting cluster cds-k8s-e2e-ci— the fix works at runtime, not only in YAML. - All 14 checks green on b652c8b, including the k3d E2E job (4m35s) and SonarCloud.
- Full suite locally: 1972 passed / 24 skipped; ruff and yamllint clean.
- CHANGELOG [Unreleased] Fixed entry present; no E-/W-codes added, so no README troubleshooting or code-collision impact; minimal 3-file diff.
Conclusion: no loose ends or gaps remain for this PR; in my judgment it is merge-ready.
|
Housekeeping: all 3 review threads are now answered and resolved — no openstaande punten meer. Re-verified on b652c8b: |
|
Admin-merged by RonaldHensbergen at 2026-10-31T12:56:24Z (merge commit 3ef8279), bypassing the pending review request from @SemTiOne (branch protection requires 1 approving review; enforce_admins is off). Quality judgment given before the admin merge: merge-klaar — all 14 CI checks green on b652c8b (incl. SonarCloud gate and the k3d E2E job showing cluster |
Closes #1040.
Follow-up from the #1027 review: the CI checkout is a detached HEAD, so
k3d-env.sh's branch-derived default named the clustercds-head. This pinsCDS_CLUSTER: cds-k8s-e2e-ciin the job env (with a comment explaining why), pins the invariant intests/test_k8s_e2e_workflow.py, and adds a CHANGELOG entry.Verified locally: full suite 1972 passed / 24 skipped, ruff and yamllint clean. The workflow itself changes, so the k8s E2E job runs on this PR and will show the new cluster name in its
make k3d-downstep.