[Fix] PR remains blocked after Roomote findings are resolved - #1512
Merged
roomote-roomote[bot] merged 4 commits intoAug 28, 2026
Conversation
Contributor
|
No new code issues found. See task
Reviewed dbf2b62 |
…issal-1g8ls7cob0tsq
Contributor
Author
|
Fixed and pushed in dbf2b62.
|
daniel-lxs
approved these changes
Aug 28, 2026
roomote-roomote
Bot
requested review from
brunobergher and
mrubens
as code owners
August 28, 2026 04:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
request_changesreviews.CHANGES_REQUESTEDstate and a normalized managed Roomote author identity.Why this change was made
Automated change-request reviews could leave a pull request blocked after all findings were addressed. The dismissal path also needed to enforce its ownership guarantee at the provider boundary rather than trusting a caller-supplied review ID.
Impact
Clean sync reviews can clear stale Roomote-owned change requests without risking dismissal of reviews from humans or unrelated bots. Unsupported providers continue to report review dismissal as an honest capability gap.