Skip to content

[Fix] PR remains blocked after Roomote findings are resolved - #1512

Merged
roomote-roomote[bot] merged 4 commits into
developfrom
fix/pr-review-dismissal-1g8ls7cob0tsq
Aug 28, 2026
Merged

[Fix] PR remains blocked after Roomote findings are resolved#1512
roomote-roomote[bot] merged 4 commits into
developfrom
fix/pr-review-dismissal-1g8ls7cob0tsq

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

​Opened on behalf of @daniel-lxs. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

  • Keep automated PR findings on inline comments and the canonical summary instead of submitting request_changes reviews.
  • Expose GitHub review IDs and states through the provider-neutral PR discussion read surface.
  • Forward review IDs through the worker MCP boundary and support provider-neutral review dismissal backed by GitHub.
  • Fetch the target GitHub review before dismissal and require both CHANGES_REQUESTED state and a normalized managed Roomote author identity.
  • Dismiss stale Roomote-authored change requests after a clean sync review, while rejecting human, unrelated-bot, and non-change-request reviews.

Why this change was made

Automated change-request reviews could leave a pull request blocked after all findings were addressed. The dismissal path also needed to enforce its ownership guarantee at the provider boundary rather than trusting a caller-supplied review ID.

Impact

Clean sync reviews can clear stale Roomote-owned change requests without risking dismissal of reviews from humans or unrelated bots. Unsupported providers continue to report review dismissal as an honest capability gap.

@roomote-community

roomote-community Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

No new code issues found. See task

  • packages/sdk/src/server/lib/pull-requests/source-control-pull-request-writes.ts:762 Restrict review dismissal to Roomote-owned CHANGES_REQUESTED reviews before forwarding the request to GitHub.
  • apps/worker/src/mcp/roomote-mcp-server/index.ts:848 Forward reviewId when invoking handleManageSourceControl so review dismissal can succeed.

Reviewed dbf2b62

@roomote-roomote

roomote-roomote Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

Fixed and pushed in dbf2b62.

  • GitHub now fetches and validates the target review before dismissal, allowing only managed Roomote authors in CHANGES_REQUESTED state.
  • Human, unrelated-bot, and non-change-request reviews are rejected before the dismissal API call.
  • reviewId is forwarded through the registered worker MCP tool so the validated dismissal path is reachable.
  • Focused SDK and worker tests, typechecks, formatting, lint, and the full pre-push suite pass.
  • Both addressed review threads are resolved.

Comment thread apps/worker/src/mcp/roomote-mcp-server/index.ts
@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review August 28, 2026 04:09
@roomote-roomote
roomote-roomote Bot merged commit 3dfd694 into develop Aug 28, 2026
17 checks passed
@roomote-roomote
roomote-roomote Bot deleted the fix/pr-review-dismissal-1g8ls7cob0tsq branch August 28, 2026 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant