Skip to content

[Improve] Deliver user notifications consistently across chat providers - #1581

Draft
roomote-roomote[bot] wants to merge 1 commit into
developfrom
refactor/user-direct-message-attempt-2eqrjtnyd6cv9
Draft

[Improve] Deliver user notifications consistently across chat providers#1581
roomote-roomote[bot] wants to merge 1 commit into
developfrom
refactor/user-direct-message-attempt-2eqrjtnyd6cv9

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

​Created by Roomote. View the task or mention @roomote-roomote for follow-up asks.

What changed

  • Replaced separate identity, single-provider send, and best-effort send APIs with one typed delivery attempt that reports unlinked, sent, or failed.
  • Made platform issue alerts derive admin eligibility and first-success delivery from the attempt result without a duplicate identity lookup.
  • Made GitHub installation approval notifications attempt every supported communication provider, including Discord.

Why this change was made

Identity preflights repeated provider mapping and destination work before delivery, while overlapping wrappers had already drifted to different provider coverage. A single provider-owned attempt contract keeps destination resolution and delivery outcomes aligned as communication providers evolve.

Impact

Platform issue retries retain their existing all-eligible-admin completion semantics with fewer database lookups. Installation approval notifications can now reach Discord-linked users, and callers can distinguish an unlinked user from an attempted delivery failure.

@roomote-community

roomote-community Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed 1055e3f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant