[Fix] Pull requests show duplicate Roomote attribution - #1582
Merged
Conversation
Contributor
mrubens
marked this pull request as ready for review
August 24, 2026 12:57
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
August 24, 2026 12:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PR-body attribution parsing now recognizes the HTML entity, HTML-escaped entity, and literal zero-width-space prefixes used before Roomote's marker comments. Write-time normalization removes every marked attribution line in the body's leading whitespace region before inserting one canonical line.
Regression coverage reproduces both the PR creation payload and the already-duplicated body shape observed on PR #1579.
Why this change was made
PR #1579 was created with both the delivery-harness attribution and the server-generated attribution because the prefixes were encoded differently. The previous first-line-only check did not reliably identify both marker-wrapped variants, so server normalization prepended instead of replacing.
Impact
Roomote-created and refreshed pull requests keep a single canonical attribution line even when callers use different zero-width-space encodings. Marker-wrapped attribution elsewhere in substantive body content remains untouched.