[Fix] Fast mode loses large Brain query results - #1587
Closed
roomote-roomote[bot] wants to merge 2 commits into
Closed
[Fix] Fast mode loses large Brain query results#1587roomote-roomote[bot] wants to merge 2 commits into
roomote-roomote[bot] wants to merge 2 commits into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
querycalls todetail: low,adaptive_return: true, andlimit: 6unless the caller explicitly provides those arguments.Why this change was made
gbrain already exposes parameters designed to control query response size. Fast mode should use those controls rather than maintaining a separate Brain-specific payload format in Roomote.
Impact
Fast Brain queries request a compact result set by default while preserving gbrain's native response contract and caller control over query detail, adaptive return, and result count.