[Fix] Discover pages inside shared Notion databases - #1825
Merged
Conversation
Contributor
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pages that live inside Notion databases (database rows) were missing from both the Memory (gbrain) collector and the deployment Notion MCP.
Root cause: Notion's search API only guarantees content directly shared with an integration — rows inherit access through their database but rarely appear in the search index (documented limitation). The collector's sweep searches
object: pageonly, and the traversal phase (#1726) could only discover databases embedded aschild_databaseblocks inside already-inventoried pages. A database shared directly with the integration (e.g. a top-level database) was therefore invisible: its rows never entered Memory. The MCP proxied the same search index, and a database ID couldn't be fetched at all (pages/{id}anddata_sources/{id}both 404 for it).Changes
Collector (
apps/bullmq/.../notion-pages.ts)searchwithfilter: data_source, feeding each into the existingdata_sourcequery path so their rows ingest like any other discovered page.dataSourceCursor/dataSourcesDonein the traverse state) and backward-compatible with in-flight cursors; an expired search cursor restarts the enumeration instead of wedging the collector.MCP (
apps/api/.../notion/tools.ts)notion-fetchgainsobject_type: "database"(GETdatabases/{id}), so agents can resolve a database ID to its data sources.notion-search's description now steers agents around the index gap: find the data source, then list rows withnotion-query-data-sources.Docs:
apps/docs/integrations/notion.mdxdescribes the database-row discovery.Tests
dataSourcesDone: trueto keep their original focus.Note: verified against Notion's API docs and unit tests (no live Notion connection in local dev). After deploy, missing rows are picked up on the next daily sweep → traverse cycle.