[Fix] Merge announcer destinations reset after saving - #1858
Merged
Conversation
Contributor
mrubens
marked this pull request as ready for review
August 29, 2026 19:42
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
August 29, 2026 19:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
automations.updateSettingstRPC boundary so non-default destinations reach persistence and rehydrate after reload.Why this change was made
The destination picker added in PR #1845 built the correct save payload, but the inline tRPC Zod schema omitted its three destination fields and stripped them before the mutation ran. The same release also reused the merged-PR icon and posted standard Markdown directly into Slack's mrkdwn surface, producing ambiguous icons and literal formatting.
Impact
Admins can save any supported Merge announcer channel or DM destination and see it remain selected after reload. Push notifications now follow Roomote's standard automation-card hierarchy, avoid repetitive author dumps and raw Markdown, and visually distinguish immediate primary-branch activity from the recurring merged-PR digest.
Screenshots