Skip to content

[Fix] Merge announcer destinations reset after saving - #1858

Merged
mrubens merged 2 commits into
developfrom
fix/merge-announcer-destination-0jy7dz1ck4vd8
Aug 29, 2026
Merged

[Fix] Merge announcer destinations reset after saving#1858
mrubens merged 2 commits into
developfrom
fix/merge-announcer-destination-0jy7dz1ck4vd8

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

​Opened on behalf of @mrubens. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

  • Preserve Merge announcer provider, Channel/DM mode, and destination ID at the automations.updateSettings tRPC boundary so non-default destinations reach persistence and rehydrate after reload.
  • Add a database-backed regression test that parses the router-owned destination schema, saves a non-default channel, reloads deployment settings, and verifies the same provider, mode, and channel.
  • Give Merge announcer a distinct commit-activity icon while keeping the merged-PR digest's megaphone, including the generated Slack card asset.
  • Replace raw Slack Markdown with the standard Roomote automation card: icon/title header, conversational push context, blockquoted summary, and View changes / Configure actions.
  • Give Teams, Telegram, and Discord the equivalent concise narrative, detail quote, and action links through their existing communication adapters.

Why this change was made

The destination picker added in PR #1845 built the correct save payload, but the inline tRPC Zod schema omitted its three destination fields and stripped them before the mutation ran. The same release also reused the merged-PR icon and posted standard Markdown directly into Slack's mrkdwn surface, producing ambiguous icons and literal formatting.

Impact

Admins can save any supported Merge announcer channel or DM destination and see it remain selected after reload. Push notifications now follow Roomote's standard automation-card hierarchy, avoid repetitive author dumps and raw Markdown, and visually distinguish immediate primary-branch activity from the recurring merged-PR digest.

Screenshots

A non-default Discord channel remains selected after saving and reloading Merge announcer

Merge announcer uses a distinct commit-activity icon beside the merged-PR digest megaphone

@roomote-community

roomote-community Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed 1b10dfd

@mrubens
mrubens marked this pull request as ready for review August 29, 2026 19:42
@mrubens
mrubens merged commit 7900283 into develop Aug 29, 2026
17 checks passed
@mrubens
mrubens deleted the fix/merge-announcer-destination-0jy7dz1ck4vd8 branch August 29, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant