Repository navigation
Code-Health-Audit #334: Farb-Tokens, toter Code, game.tsx State-Cluster - #343
Merged
Merged
Conversation
… game.tsx State-Cluster) Behebt alle drei offenen Befunde aus Issue #334: - TimerArc.native.tsx/.web.tsx referenzieren die Timer-Zustandsfarben jetzt über eine gemeinsame TimerArc.shared.ts + Colors.timerArc-Tokens statt hartkodierter Hex-Duplikate; app/index.tsx nutzt für Daily-Challenge- und Streak-Akzente ebenfalls zentrale Colors.accents-Tokens. - Ungenutzten AnimatedButton-Export aus AnimatedPrimitives.tsx entfernt (inkl. Test-Mock und CLAUDE.md-Referenz). - Confetti-/Badge-Toast-/Hint-Modal-State aus app/game.tsx in einen dedizierten useGameFeedback()-Hook ausgelagert, analog zu useGamePhase/ useTimer. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MbKegWQy8DNKFvzAfVKNbt
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MbKegWQy8DNKFvzAfVKNbt
🔀 Mergeability-Report✅ Konfliktfrei mergebar ( CI-Checks: ✅ keine fehlgeschlagenen Checks ⏳ 🔒 Security Audit Merge-Checkliste
Kostenlos generiert von reusable-mergeability.yml · keine API-Kosten · review-gate: |
5 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Behebt alle drei offenen Befunde aus Issue #334 (Code-Health-Audit 2026-09-20):
TimerArc.native.tsx/TimerArc.web.tsxhatten identisch hartkodierte Hex-Werte (#FF6B6B/#FFD700/#FFFFFF). DiearcColor-Logik ist jetzt incomponents/game/TimerArc.shared.ts(getTimerArcColor()) zusammengefasst und referenziert neueColors.timerArc.*-Tokens. Die zusätzlich genannten Hex-Literale inapp/index.tsx(Daily-Challenge-Akzent, Streak-Badge) sind jetztColors.accents.*-Tokens.AnimatedButton-Export ausAnimatedPrimitives.tsxentfernt (unbenutzt außerhalb eines Test-Mocks), inkl. Mock inGalleryScreen.test.tsxund Referenzen inCLAUDE.md.game.tsxState-Cluster (Niedrig): Confetti-/Badge-Toast-/Hint-Modal-State (7useState+ Achievement-Check-Logik) ausapp/game.tsxin einen neuenuseGameFeedback()-Hook ausgelagert (services/useGameFeedback.ts), analog zum bestehendenuseGamePhase/useTimer-Muster. Reduziert dieeslint-disable-next-line react-hooks/exhaustive-deps-Stellen ingame.tsxvon 3 auf 2.Reine Refactoring-/Aufräumarbeit ohne Verhaltensänderung.
Test plan
npx tsc --noEmit— saubernpm run lint— saubernpm test— 460/460 Tests grünnpm run validate:svg-counts— 81 Einträge validenpm run format:check(via Pre-Push-Hook) — sauberCloses #334
🤖 Generated with Claude Code
https://claude.ai/code/session_01MbKegWQy8DNKFvzAfVKNbt
Generated by Claude Code