Add websocket_connected metric and configurable prometheus_job_id - #46
Closed
vineeshah wants to merge 1 commit into
Closed
Add websocket_connected metric and configurable prometheus_job_id#46vineeshah wants to merge 1 commit into
vineeshah wants to merge 1 commit into
Conversation
adarshm11
reviewed
Sep 3, 2026
adarshm11
left a comment
Contributor
There was a problem hiding this comment.
looks good but can we split into two PRs, one resolving each issue
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #44 and #45.
#44 - new websocket_connected gauge (1 connected / 0 not), set on smee connect and reset in the finally so every disconnect path reports 0.
#45 - parse optional prometheus_job_id from config.yml so multiple sce-cicd instances stop overwriting each other's pushgateway metrics. Falls back to "sce-cicd" when unset.
Tested locally against smee2 + one.sce: connect→1, kill smee2→0, custom job id lands as its own group, mock push pushes last_push_timestamp{repo}. Screenshot of test added below.