Repository navigation
Don't measure correspondence quality on areas held out by constraints. - #2674
Merged
Merged
Conversation
The correspondence-quality metric scored the whole groomed surface, including regions removed by cutting planes and free-form constraints, where the optimizer places no particles. The CLI also warped from an unclipped template, so the reconstruction extrapolated a surface into the cut-away region. Cut-away vertices are now left out of the statistics and set to zero in the output fields. The normalization bounding box covers only the kept surface, and the CLI clips the template mesh as Studio already does. Adds a small cutting-plane ellipsoid dataset and regression tests.
akenmorris
force-pushed
the
amorris/2673-cq-constraints
branch
from
October 21, 2026 15:38
d7ffde1 to
2616150
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2673
The correspondence-quality metric scored the whole groomed surface, including regions removed by cutting planes and free-form constraints, where the optimizer places no particles. The CLI also warped from an unclipped template, so the reconstruction extrapolated a surface into the cut-away region.
Cut-away vertices are now left out of the statistics and set to zero in the output fields. The normalization bounding box covers only the kept surface, and the CLI clips the template mesh as Studio already does. Adds a small cutting-plane ellipsoid dataset and regression tests.