Meters chart, Export AT XML, and create column functionality - #84
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds new end-user functionality across the Organizations Columns UI and Inventory Detail Meters view, and wires up an export action for Audit Template XML via the existing v3 API.
Changes:
- Add a “New Column” action that opens a create-column modal and refreshes the columns list on success.
- Add a client-side filtered readings chart (Chart.js) and collapsible readings table on the Meters detail page.
- Enable “Export Audit Template File (XML)” and implement the corresponding API call + browser download behavior.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/modules/organizations/columns/list/modal/create-modal.component.ts | New create-column dialog component logic using ColumnService. |
| src/app/modules/organizations/columns/list/modal/create-modal.component.html | New create-column dialog UI. |
| src/app/modules/organizations/columns/list/list.component.ts | Adds createColumn() flow and post-close refresh of column data. |
| src/app/modules/organizations/columns/list/list.component.html | Adds “New Column” button to the columns list header area. |
| src/app/modules/inventory-detail/meters/meters.component.ts | Adds client-side readings filtering and Chart.js line chart rendering. |
| src/app/modules/inventory-detail/meters/meters.component.html | Adds collapsible readings table header and a readings chart canvas section. |
| src/app/modules/inventory-detail/detail/header.component.ts | Enables the Audit Template XML export action and triggers a file download. |
| src/@seed/api/column/column.service.ts | Adds createColumn() API wrapper to POST to /api/v3/columns/. |
| src/@seed/api/audit-template/audit-template.service.ts | Adds exportBuildingSyncAtFile() API wrapper to GET XML as text. |
| public/i18n/en_US.json | Adds new identity translation keys used by the updated UI. |
| public/i18n/es.json | Adds Spanish translations for new identity keys. |
| public/i18n/fr_CA.json | Adds French (CA) translations for new identity keys. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1
to
+5
| <h2 mat-dialog-title>Create Column</h2> | ||
|
|
||
| <mat-dialog-content> | ||
| <mat-form-field class="w-full"> | ||
| <mat-label>Column Name</mat-label> |
Contributor
There was a problem hiding this comment.
Implemented in 23e88c0: updated the create-column modal strings to use *transloco="let t" and added the missing identity key (This name is already in use.) in public/i18n/en_US.json.
Comment on lines
102
to
105
| name: 'Export Audit Template File (XML)', | ||
| action: () => { | ||
| this.tempAction() | ||
| }, | ||
| disabled: true, | ||
| action: () => { this.exportAuditTemplateXml() }, | ||
| disabled: !isProperties, | ||
| }, |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: kflemin <2205659+kflemin@users.noreply.github.com>
Co-authored-by: kflemin <2205659+kflemin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.