Repository navigation
fix(room): evict Redis room projections on session end - #459
Merged
Merged
Conversation
On logout or session timeout, drop the Redis room projections for every room the session (and its agent user) loaded. They reload from the database on next open.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Redis room projections outlived the session that loaded them and were never cleaned up.
Changes
UserSessionLoader.sessionDestroyednow callsRoomMessageStore.evictRedisProjectionsfor every room in the session user's (and agent user's)roomHash. This runs on both explicit logout and session timeout, independent of cluster mode. It's best-effort: failures are logged, and evicted rooms reload from the database on next open.Depends on
SEMOSS/Semoss#3184 (adds
RoomMessageStore.evictRedisProjectionsand the TTL).Testing (local Monolith + Redis)
Loaded a room (key present, TTL 3600), called
/api/auth/logout/all. The log showed "has logged out to end session" and the key was gone.