Skip to content

feat(engine): close an engine on every node after its smss secrets change #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
themaherkhalil merged 1 commit into from
Oct 26, 2026
Merged

feat(engine): close an engine on every node after its smss secrets change #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/prerna/semoss/web/services/local/EngineRouteResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,10 @@ public Response updateSmssFile(@Context HttpServletRequest request, @PathParam("
return WebUtility.getResponse(errorMap, 400);
}

// the smss file is unchanged and the new values live in the secret store, so
// the other nodes only need to close the engine to read them on next use
ClusterUtil.publishEngineClose(engineId);

Map<String, Object> success = new HashMap<>();
success.put("success", true);
return WebUtility.getResponse(success, 200);
Expand Down
3 changes: 2 additions & 1 deletion src/prerna/web/services/util/WebUtility.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
import java.util.HashSet;
import java.util.LinkedHashSet;
import java.util.List;
import java.util.Map;
import java.util.TimeZone;
import java.util.regex.Pattern;
import java.util.stream.Collectors;
Expand Down Expand Up @@ -247,7 +248,7 @@ private static void auditErrorResponse(Object vec, int status) {
if (status < 400) {
return;
}
Object message = vec instanceof java.util.Map<?, ?> map ? map.get(Constants.ERROR_MESSAGE) : vec;
Object message = vec instanceof Map<?, ?> map ? map.get(Constants.ERROR_MESSAGE) : vec;
UserAuditTrailUtils.recordHttpErrorResponse(status, message instanceof String text ? text : null);
}

Expand Down
Loading