Skip to content

MCP-level resolution failures #3190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ckelly17 wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

MCP-level resolution failures #3190

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
45cf4d7
Load workspace MCP tools independently so one bad resource can't drop…
claude Oct 23, 2026
dc20419
Merge branch 'dev' into claude/editworkspace-tool-access-bug-pflbec
ckelly17 Oct 23, 2026
866e046
Merge branch 'dev' into claude/editworkspace-tool-access-bug-pflbec
ckelly17 Oct 26, 2026
9f656ab
Merge branch 'dev' into claude/editworkspace-tool-access-bug-pflbec
ckelly17 Oct 26, 2026
d8c296e
Merge branch 'dev' into claude/editworkspace-tool-access-bug-pflbec
kunal0137 Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions src/prerna/engine/impl/model/Room.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1372,11 +1372,18 @@ public List<Map<String, Object>> getAllToolsJsonForRoom(int maxLength, boolean s
List<Map<String, Object>> tools = ModelInferenceLogsUtils.getWorkspaceResourcesIgnoringType(
workspaceId, Arrays.asList(AbstractWorkspaceReactor.PROMPT_RESOURCE_TYPE,
AbstractWorkspaceReactor.SKILL_RESOURCE_TYPE));
for (Map<String, Object> tool : tools) {
for (Map<String, Object> tool : tools != null ? tools : List.<Map<String, Object>>of()) {
String toolId = (String) tool.get("resource_id");
if (!ensureUnique.contains(toolId)) {
aggregated.addAll(getToolJson(toolId, maxLength, sanitizeToolNamesForLLM, lookup));
ensureUnique.add(toolId);
// marked seen even on failure so CONFIG_JSON.mcps doesn't retry it
if (toolId != null && ensureUnique.add(toolId)) {
// one resource that can't produce tools (e.g. a knowledge base without
// MCP enabled) must not drop the workspace's remaining tools
try {
aggregated.addAll(getToolJson(toolId, maxLength, sanitizeToolNamesForLLM, lookup));
} catch (Exception e) {
classLogger.warn("Skipping workspace mcp {} for workspaceId={}: {}", toolId,
workspaceId, e.getMessage());
}
}
}
} catch (Exception e) {
Expand All @@ -1394,9 +1401,14 @@ public List<Map<String, Object>> getAllToolsJsonForRoom(int maxLength, boolean s
continue;
}
String toolId = mcp.optString("id", null);
if (toolId != null && !toolId.isEmpty() && !ensureUnique.contains(toolId)) {
aggregated.addAll(getToolJson(toolId, maxLength, sanitizeToolNamesForLLM, lookup));
ensureUnique.add(toolId);
if (toolId != null && !toolId.isEmpty() && ensureUnique.add(toolId)) {
try {
aggregated.addAll(
getToolJson(toolId, maxLength, sanitizeToolNamesForLLM, lookup));
} catch (Exception e) {
classLogger.warn("Skipping CONFIG_JSON mcp {} for workspaceId={}: {}", toolId,
workspaceId, e.getMessage());
}
}
}
}
Expand Down
Loading