Repository navigation
Collaboration routines: Reference documents tab, full-height result panels, livelier running state - #3798
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Routine cards in Collaboration get a Reference documents tab backed by the shared file dock, the result panels fill the card instead of stopping at a fixed height, and the in-progress state is a proper centered panel.
Reference documents tab
custom-routine-card.tsx: the right column is now a tab pair, Latest result and Reference documents, in the shared collaboration tab style.routine-documents.tsx(new): opens the routine's folder withWorkRoutineDocuments(routineId), with loading and error states, then mounts the dock.routine-documents-dock.tsx(new): the same dock as Settings > My Files (FILE_PANEL_COMPONENTS, the file explorer in USER mode) rooted at the routine folder throughinitialPath. Compact layout below 768px of container width, rail layout above. A Maximize action in the rail opens it over the page like My Files. The frame around the shell is positioned, because the workbench shell isabsolute inset-0and otherwise fills the page.custom-routine-api.ts,custom-routine-schema.ts:openRoutineDocumentsand its schema.shortcut:comment: the explorer's breadcrumbs can climb above the routine folder into the rest of the owner's files.Result panels fill the column
routine-result.tsx: the scroll box grows to the bottom of the settings column and keeps 32rem as its minimum. It sits in an out-of-flow wrapper so a long brief scrolls inside the box instead of stretching the card. The wrapper carries the positioning because the Radix scroll area root pinsposition: relativeinline. A newshowTitleprop hides the heading when a tab already names the section.inbox-routine-form.tsx,agenda-routine-form.tsx: the result wrapper is a flex column so the same growth applies to those cards.Running state
routine-running.tsx(new): a breathing agent mark (pulse only undermotion-safe), the routine's status sentence in a status region that is announced once, a live elapsed timer kept outside the live region so it is not read out every second, and a primary Watch it run button. It replaces the inline spinner and fills the frame. Shared by all three routine types.