Repository navigation
Collaboration Routines: Expense review tab and document upload button - #3802
Merged
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Expense review routine to the Routines page and gives the routine documents dock a visible Upload documents button. Pairs with the Semoss PR that adds the
WorkGetExpenseRoutine,WorkSaveExpenseRoutineandWorkRunExpenseRoutinereactors; the tab needs that server build.What changed
Expense review tab (
packages/collaboration/src/features/routines)expense-routine-schema.ts: settings areenabledandtimezoneonly (the routine runs when a request arrives, not on a schedule); the routine record addsid: "expense-review",documentsId(fixed guideline folder id) andsubjects(the trigger prefixes), plus the shared status and flow shapes.expense-routine-api.ts:saveExpenseRoutine->WorkSaveExpenseRoutine(settings=...).expense-routine-form.tsx: autosaving on/off switch with the trigger wording built fromsubjects, a short "How a review works" list, and a right column of tabs: Latest review (RoutineResult) and Guideline documents (RoutineDocumentsrooted atdocumentsId). Availability and flow sections as the other routines.routines-workspace.tsx: new "Expense review" tab, loaded lazily on first open like the agendas tab.routine-copy.ts:EXPENSE_RESULT_COPY.routine-schema.ts:RoutineIdincludes"expense-review".routine-card-header.tsx: optionalenabledLabelprop so this routine's badge reads "On" instead of "Scheduled".Upload button in the documents dock
routine-documents-dock.tsx: the explorer's own New control is a panel-tab chrome control, and the dock's compact shell (the card column is under 768px) draws tabs without controls, so there was no visible way to upload. The dock now renders an "Upload documents" button in the shell's top toolbar (borderSlots.top.beforewithmobileTopBorder="toolbar"), shown in both the compact and the maximized layout. It reads the explorer API from the panel store and opens the upload form directly (openNewFile(undefined, "upload")) at the routine's folder. Custom routines get the same button.