Repository navigation
Fix APM cold installs and manage CLI updates with Dependabot - #271
Merged
Merged
Conversation
Avoid the cold frozen-install regression reported upstream in microsoft/apm#3372. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Install the pinned pip dependency in an isolated CI virtual environment and exclude APM 0.35.0 because of microsoft/apm#3372. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
No concrete defects were identified, but CLI installation and the Linux cold-install/audit flow remain unvalidated.
No open issues 🎉
What changed in this PR
This PR makes APM skill-update automation use a pinned CLI version to avoid the reported cold-install regression, while managing future updates through Dependabot.
Changes:
- Pin
apm-clito0.34.0and install it in an isolated runner-temporary Python virtual environment. - Enable daily Dependabot pip updates, excluding the known-broken
0.35.0release. - Document the shared CLI pin and upstream regression reference.
| File | Description |
|---|---|
tools/apm/requirements.txt |
Pins the CLI version and references the upstream regression. |
.github/workflows/apm-update.yml |
Replaces the latest-version installer with installation from requirements in a virtual environment. |
.github/dependabot.yml |
Adds daily pip updates with a 0.35.0 exclusion. |
.github/copilot-instructions.md |
Documents the shared pin and workflow installation requirement. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apm-cli==0.34.0intools/apm/requirements.txtand install it into an isolated runner-temporary Python virtual environment instead of downloading the latest CLI./tools/apm, excluding only the known-broken 0.35.0 release. Preserve the upstream regression reference in the requirements comment and document the shared pin location for contributors.Related Issues
N/A - no issue to close.
Upstream regression: microsoft/apm#3372.
Scope
Validation
dotnet build RepoSyncRadar.sln -warnaserrornot run; changes affect tooling configuration only, not application code.dotnet test RepoSyncRadar.sln -- --filter-not-trait Category=Manualnot run; changes affect tooling configuration only, not application code.python -c "import yaml; [yaml.safe_load(open(p, encoding='utf-8')) for p in ('.github/dependabot.yml', '.github/workflows/apm-update.yml')]; print('YAML syntax OK')"passed;git diff --checkpassed;gh actions-lockpassed;gh actions-lock --verifypassed (all 6 workflows valid, lockfile unchanged).Additional validation limits:
ghalint runcould not run because ghalint and Go are not installed locally.pip install --requirement tools/apm/requirements.txtattempt failed because the configured package feed returned HTTP 404. Retrying against public PyPI failed with a TLS handshake error to files.pythonhosted.org. The package metadata confirms that 0.34.0 exists, but CLI startup and the Linux cold-install/audit flow were not executed locally.Risk And Rollback
Release Notes
Release note draft:
Pin the APM CLI to a working release and manage future CLI updates through Dependabot instead of consuming unreviewed latest releases.