Skip to content

utils: pxrad: fix missing sky after #f7892c4 #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SNMetamorph merged 1 commit into from
Oct 11, 2026
Merged

utils: pxrad: fix missing sky after #f7892c4 #297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion utils/pxrad/qrad.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2406,8 +2406,10 @@ void CollectLight( void )
for( j = 0; j < MAXLIGHTMAPS && newstyles[i][j] != 255; j++ )
{
VectorAdd( patch->directlight[j], addlight[i][j], patch->totallight[j] );
VectorAdd( patch->totallight[j], patch->samplelight[j], patch->totallight[j] );
#ifdef HLRAD_DELUXEMAPPING
VectorAdd( patch->directlight_dir[j], addlight_dir[i][j], patch->totallight_dir[j] );
VectorAdd( patch->totallight_dir[j], patch->samplelight_dir[j], patch->totallight_dir[j] );
#endif
}
memcpy( g_patches[i].totalstyle, newstyles[i], sizeof( byte[MAXLIGHTMAPS] ));
Expand All @@ -2420,6 +2422,7 @@ void CollectLight( void )
for( j = 0; j < MAXLIGHTMAPS && newstyles[i][j] != 255; j++ )
{
VectorAdd( patch->directlight[j], addlight[i][j], patch->totallight[j] );
VectorAdd( patch->totallight[j], patch->samplelight[j], patch->totallight[j] );
VectorMultiply( patch->totallight[j], patch->reflectivity, patch->totallight[j] );
}
memcpy( g_patches[i].totalstyle, newstyles[i], sizeof( byte[MAXLIGHTMAPS] ));
Expand Down Expand Up @@ -2546,8 +2549,9 @@ void BounceLight( void )

for( j = 0; j < MAXLIGHTMAPS && g_patches[i].totalstyle[j] != 255; j++ )
{
VectorCopy( patch->directlight[j], patch->totallight[j] );
VectorSubtract( patch->totallight[j], patch->directlight[j], patch->samplelight[j] ); //use samplelight for patch lighting (sky, fastlights, etc.)
#ifdef HLRAD_DELUXEMAPPING
VectorSubtract( patch->totallight_dir[j], patch->directlight_dir[j], patch->samplelight_dir[j] );
VectorClear( addlight_dir[i][j] );
#endif
}
Expand Down
Loading